Xinru Zhang
Xinru Zhang
/hold this PR until TEP-0121 is implemented.
> do I need `conversions`, like stated [here](https://github.com/tektoncd/pipeline/blob/df7abd26b9800c767fb49897aaaf945dd76ced3c/config/300-pipeline.yaml#L70-L77), for v1alpha1.Runs to v1beta1.CustomRuns? From the API compatibility policy perspective, it's okay that we don't convert it (per `Rule #2` in [K8s...
I would say the main focus is how do we want our users to conceive the "alpha" feature. IMHO alpha version track is designed to serve as experimental features, meaning...
Putting a note here as a reminder: all the references about `v1alpha1.Run` should be migrated to `v1beta1.CustomRun`, for example: https://github.com/tektoncd/pipeline/blob/f1b68123b2de6c5fe05b0db3a98ca77b56e8a91f/pkg/apis/pipeline/v1alpha1/run_types.go#L101-L107 Thanks for @lbernick 's input!
Pushed a new commit comparing related works.
I'm moving this TEP to `implementable` as we've fully discussed the options in [Tekton API Working Group](https://docs.google.com/document/d/17PodAxG8hV351fBhSu7Y_OIPhGTVgj6OJ2lPphYYRpU/edit#bookmark=id.7qh0pag5wnc), PTAL~
1. We need to document clearly **the end condition of a Custom Run**. - For now, we [rely on both `Condition` and `retriesStatus`](https://github.com/tektoncd/pipeline/blob/e1fd72720652fa5a1b7f811a6ce1d6c943be11a6/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go#L198): `IsDone() & len(retriesStatus)==retries` - And it is...
> thanks Xinru for this summary! I think we should remove `status.retriesStatus` from v1beta1.CustomRun instead of only changing the docs and PR reconciler code. Thanks @lbernick! Right, updated the sumary...
Hi everyone, I'm moving this to proposed, hope we can check it in and iterate it later on. LMK if you have other concerns. cc @afrittoli @pritidesai @lbernick @jerop @dibyom