Gavin Xin

Results 298 comments of Gavin Xin

golangci-lint(macos-latest) will fail if we only rename port_table_linux.go to port_table_others.go. So add port_table_others.go to handle situations other than linux and windows environment.

> I'd rather merge #3936 first and then see what else we need to do Sure, #3936 is also ready for review.

/test-all /test-windows-all

/test-all /test-windows-all

> I don't think we should add a brand new port_table file just to run unit tests on macOS. Why don't we use the Linux one? Updated. I think we...