finn-base icon indicating copy to clipboard operation
finn-base copied to clipboard

Latest protobuf version not compatible with current onnx version

Open jacobolofsson opened this issue 3 years ago • 1 comments

finn-base[onnx] is pinned to use onnx==1.7.0, which is not compatible with protobuf>3.20. This is solved in onnx==1.12 by introducing an upper constraint on the protobuf version (https://github.com/onnx/onnx/issues/4222)

Possible solutions would be:

  1. Upgrade onnx to >= 1.12
  2. Add protobuf<3.21 as a direct dependency

I would be happy to create a PR to implement either of these

jacobolofsson avatar Aug 11 '22 14:08 jacobolofsson

Hi Jacob, thanks for pointing this out. This repo (finn-base) is scheduled to be deprecated soon, and should be replaced in any dependent projects with the new QONNX (https://github.com/fastmachinelearning/qonnx) repo. QONNX is nearly a drop-in replacement for finn-base, only a namespace change is needed (e.g. import finn.core.modelwrapper becomes import qonnx.core.modelwrapper).

maltanar avatar Aug 17 '22 19:08 maltanar