embeddedsw icon indicating copy to clipboard operation
embeddedsw copied to clipboard

Implement guard against overrun in XEmacPs_BdRingFromHwRx.

Open kristiankjar opened this issue 2 years ago • 3 comments

Please do not submit a Pull Request via github. Our project makes use of mailing lists for patch submission and review. For more details please see https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842172/Create+and+Submit+a+Patch

kristiankjar avatar Oct 05 '22 13:10 kristiankjar

Hopefully you can get this one approved somehow. I reported this in 2019 with a proposed fix and it is still affecting customers. Supposedly it is going to be fixed in 2022.2:

https://support.xilinx.com/s/question/0D52E00006hpmNcSAI/ip-rx-stack-crashes?language=en_US

We already have fixed this in 2022.2.

anirudha1977 avatar Oct 06 '22 04:10 anirudha1977

That's good to hear. I was working off of tag xilinx_v2022.1_update3 when looking for it, so I guess I must have been very close. Would have saved me half a week of work tracking this down if the fix had been in the repo already.

Incidentally, could you maybe add a CONTRIBUTING file or similar at the root of the repo, so one doesn't have to go all the way to creating the actual pull request, before being asked not to? We don't use git-email in my organisation, so it was a bit of a bother trying to send you the patch by the proscribed route.

kristiankjar avatar Oct 06 '22 06:10 kristiankjar