dma_ip_drivers icon indicating copy to clipboard operation
dma_ip_drivers copied to clipboard

"Engine was not running" message should be printed not only when debug enabled

Open dmitrym1 opened this issue 11 months ago • 0 comments

In current code, message "Engine was not running!!! Clearing status\n" is printed with dbg_tfr macro that only prints when module is built with LIBXDMA_DEBUG flag. However, building with this flag enables many other debug messages and bloats the log. I suggest to replace dbg_tfr with pr_err for this message. This message only appears when XDMA IP says that transaction is complete but the kernel module did not expect that (because it timed out previously or some other error). In other words, this message shows that there was a synchronization issue between requester and completer parts of the driver. So this message should be a good starting point for further diagnostics

dmitrym1 avatar Jan 17 '25 13:01 dmitrym1