device-tree-xlnx icon indicating copy to clipboard operation
device-tree-xlnx copied to clipboard

Published 20 hours ago • verified publisher icon Xilinx

dp_rx/data/dp_rx.tcl: unbreak vid_phy direction

Open jacmet opened this issue 5 months ago • 2 comments

Commit edb1f978f719b (vid_phy_ctrl:hdmi_gt_ctrl: Generate Channels only if connected to DP/HDMI) broke the vid_phy direction setting as it set the 4th cell to 1 instead of 0.

As specified by the binding, the 4th cell encodes the phy directions:

direction_tx = 0 for RX and 1 for TX

https://github.com/Xilinx/dp-modules/blob/xlnx_rel_v2024.1/Documentation/devicetree/bindings/xlnx%2Cvphy.txt

So setting it to 1 doesn't make any sense for the DP receiver core. This seems to be a cut'n'paste mistake from the similar logic in the DP transmitter core.

Fixes: edb1f978f719b ("vid_phy_ctrl:hdmi_gt_ctrl: Generate Channels only if connected to DP/HDMI")

jacmet avatar Sep 26 '24 19:09 jacmet