device-tree-xlnx icon indicating copy to clipboard operation
device-tree-xlnx copied to clipboard

emacps: Fix error when multiple PCSPMA IP are instantiated

Open patocarr opened this issue 4 years ago • 1 comments

Details on this post: https://forums.xilinx.com/t5/Embedded-Linux/Petalinux-2020-1-fails-to-generate-default-device-tree-but-works/td-p/1119777

patocarr avatar Jul 23 '20 06:07 patocarr

I can confirm that this fixes the compile error but the device tree that comes out isn't quite correct with 2 x PCS/PMA blocks:

&gem0 {
	phy-handle = <&phy7>;
	phy-mode = "gmii";
	status = "okay";
	xlnx,ptp-enet-clock = <0x0>;
};
&gem1 {
	phy-handle = <&phy7>;
	phy-mode = "gmii";
	status = "okay";
	xlnx,ptp-enet-clock = <0x0>;
	phy7: phy@7 {
		reg = <0x07>;
		xlnx,phy-type = <0x5>;
	};
};

It only creates one PHY node and connects both GEMs to the one node. They should each have their own node and appropriate handles.

EDIT: This is easy to fix in the system-user.dtsi but could be a trap for people who aren't aware of it

IsaacJT avatar Jun 18 '21 09:06 IsaacJT