XRT icon indicating copy to clipboard operation
XRT copied to clipboard

Add PID argument to aie mem and reg read/write apis

Open rbramand-xilinx opened this issue 1 year ago • 3 comments
trafficstars

Problem solved by the commit

Added PID argument to aie debug apis to uniquely identify hw ctx.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

How problem was solved, alternative solutions (if any) and why they were rejected

Context ID alone doesn't uniquely identify a hw context as per driver implementation, so added extra PID arg to debug APIs.

Risks (if any) associated the changes in the commit

Low

What has been tested and how, request additional testing if necessary

Tested the flow on both Linux and windows and the apis work as expected.

Documentation impact (if any)

Added doxygen comment for the arg added

rbramand-xilinx avatar Jul 08 '24 09:07 rbramand-xilinx

In both Linux and Windows we print PID now using xrt-smi, the same can be provided to debug apis. Rebased the changes with latest XRT, please review. Thanks

rbramand-xilinx avatar Oct 22 '24 07:10 rbramand-xilinx

@rbramand-xilinx, can you please update the description of this PR? It looks old

AShivangi avatar Oct 22 '24 16:10 AShivangi

So are these APIs are called from a different process compared to the process that opened the hw_context (the pid argument)?

Yes Soren, it will be called from debugger process. Pair <context id, pid> uniquely identifies a hw_context

rbramand-xilinx avatar Oct 23 '24 05:10 rbramand-xilinx