XRT icon indicating copy to clipboard operation
XRT copied to clipboard

Release Python GIL during slow load I/O

Open andrew-bolin opened this issue 1 year ago • 5 comments

Problem solved by the commit

When using multiple FPGAs in multiple threads, loading XCLBINs cannot be performed concurrently as pyxrt holds the Python Global Interpreter Lock for the duration of the loading process.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

See AMD WTS support case 00410749

How problem was solved, alternative solutions (if any) and why they were rejected

GIL released during slow load operation. This fix was suggested by AMD support in November 2023, but was seemingly never submitted to the code base.

Risks (if any) associated the changes in the commit

Believed to be safe

What has been tested and how, request additional testing if necessary

AMD support said they have tested it. A Python snippet to demonstrate the original issue (and prove the fix) is available - https://gitlab.com/ska-telescope/low-cbf/ska-low-cbf-fpga/-/snippets/3613095

Documentation impact (if any)

None

andrew-bolin avatar Apr 11 '24 04:04 andrew-bolin

andrew-bolin - is not a collaborator Can XRT admins please validate PR

gbuildx avatar Apr 11 '24 04:04 gbuildx

Can one of the admins verify this patch?

gbuildx avatar Apr 11 '24 04:04 gbuildx

andrew-bolin - is not a collaborator Can XRT admins please validate PR

gbuildx avatar May 02 '24 14:05 gbuildx

\build

chvamshi-xilinx avatar Jun 05 '24 08:06 chvamshi-xilinx