XRT
XRT copied to clipboard
HIP tests for GPU and other build improvements
Problem solved by the commit
- Provide a switch for disabling bundling of Alveo drivers with XRT package
- Fix a build failure on Ubuntu 23.10
- Add Makefiles for HIP tests to run then on AMD GPU
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
NA
Risks (if any) associated the changes in the commit
NA
What has been tested and how, request additional testing if necessary
- Build tested with default build switches and with -noalveo switch
- Install tested both debian files.
Documentation impact (if any)
NA. This does not change the default behavior of XRT build.
Fix a build failure on Ubuntu 23.10: I think I fixed this already with https://github.com/Xilinx/XRT/pull/8003
Assuming you have tested the produced package when driver is not bundled and it installs fine. Just wondering if anything needs changing in post install script.
Thanks for reminding, I overlooked the postinst script. Let me validate install/uninstall and update the PR.
Can you rebase please? I think the xrt_graph.cpp change was from #8003 which has been merged.
Done
Assuming you have tested the produced package when driver is not bundled and it installs fine. Just wondering if anything needs changing in post install script.
Thanks for reminding, I overlooked the postinst script. Let me validate install/uninstall and update the PR.
Made updates to postinst script to skip Alveo steps. Install tested both artifacts.
Assuming you have tested the produced package when driver is not bundled and it installs fine. Just wondering if anything needs changing in post install script.
Thanks for reminding, I overlooked the postinst script. Let me validate install/uninstall and update the PR.
Made updates to postinst script to skip Alveo steps. Install tested both artifacts.
Looks good :-)