XRT icon indicating copy to clipboard operation
XRT copied to clipboard

HIP tests for GPU and other build improvements

Open sonals opened this issue 11 months ago • 5 comments

Problem solved by the commit

  1. Provide a switch for disabling bundling of Alveo drivers with XRT package
  2. Fix a build failure on Ubuntu 23.10
  3. Add Makefiles for HIP tests to run then on AMD GPU

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

NA

How problem was solved, alternative solutions (if any) and why they were rejected

NA

Risks (if any) associated the changes in the commit

NA

What has been tested and how, request additional testing if necessary

  1. Build tested with default build switches and with -noalveo switch
  2. Install tested both debian files.

Documentation impact (if any)

NA. This does not change the default behavior of XRT build.

sonals avatar Mar 12 '24 22:03 sonals

Fix a build failure on Ubuntu 23.10: I think I fixed this already with https://github.com/Xilinx/XRT/pull/8003

keryell avatar Mar 12 '24 23:03 keryell

Assuming you have tested the produced package when driver is not bundled and it installs fine. Just wondering if anything needs changing in post install script.

Thanks for reminding, I overlooked the postinst script. Let me validate install/uninstall and update the PR.

sonals avatar Mar 13 '24 02:03 sonals

Can you rebase please? I think the xrt_graph.cpp change was from #8003 which has been merged.

Done

sonals avatar Mar 14 '24 22:03 sonals

Assuming you have tested the produced package when driver is not bundled and it installs fine. Just wondering if anything needs changing in post install script.

Thanks for reminding, I overlooked the postinst script. Let me validate install/uninstall and update the PR.

Made updates to postinst script to skip Alveo steps. Install tested both artifacts.

sonals avatar Mar 14 '24 22:03 sonals

Assuming you have tested the produced package when driver is not bundled and it installs fine. Just wondering if anything needs changing in post install script.

Thanks for reminding, I overlooked the postinst script. Let me validate install/uninstall and update the PR.

Made updates to postinst script to skip Alveo steps. Install tested both artifacts.

Looks good :-)

maxzhen avatar Mar 14 '24 22:03 maxzhen