XRT icon indicating copy to clipboard operation
XRT copied to clipboard

xbmgmt dump -f error fix

Open saumyag-xilinx opened this issue 2 years ago • 10 comments

Signed-off-by: Saumya [email protected]

Problem solved by the commit

https://jira.xilinx.com/browse/CR-1129024

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

The issue was discovered during the PR review of https://github.com/Xilinx/XRT/pull/6567#pullrequestreview-944647785 It was figured that the execution of "xbmgmt dump -f ..." would not return a non zero value in case any internal error occurred.

saumyag-xilinx avatar Sep 29 '22 06:09 saumyag-xilinx

Build Failed! :(

gbuildx avatar Sep 29 '22 07:09 gbuildx

Build Failed! :(

gbuildx avatar Sep 29 '22 18:09 gbuildx

retest this please. Failed due to https://jira.xilinx.com/browse/CR-1130285

dayeh-xilinx avatar Sep 29 '22 19:09 dayeh-xilinx

Build Failed! :(

gbuildx avatar Sep 29 '22 21:09 gbuildx

retest this please.

dayeh-xilinx avatar Sep 30 '22 04:09 dayeh-xilinx

Build Passed!

gbuildx avatar Sep 30 '22 07:09 gbuildx

Build Failed! :(

gbuildx avatar Oct 11 '22 11:10 gbuildx

retest this please.

dayeh-xilinx avatar Oct 11 '22 18:10 dayeh-xilinx

Build Passed!

gbuildx avatar Oct 11 '22 21:10 gbuildx

Updated the PR with the requested change. @rozumx kindly review it.

saumyag-xilinx avatar Oct 12 '22 08:10 saumyag-xilinx

Updated the PR with the requested change. @rozumx please review it.

saumyag-xilinx avatar Oct 20 '22 16:10 saumyag-xilinx

Build Passed!

gbuildx avatar Nov 08 '22 19:11 gbuildx