XRT icon indicating copy to clipboard operation
XRT copied to clipboard

CR-1136632 : Get tiles for AIE_profile_settings.tile_based_interface_tile_metrics and remove stray white space characters in configurations

Open IshitaGhosh opened this issue 3 years ago • 7 comments

Problem solved by the commit

Tiles specified with AIE_profile_settings.tile_based_interface_tile_metrics were not selected for profiling.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

CR 1136632 reported the issue

How problem was solved, alternative solutions (if any) and why they were rejected

For SHIM profiling, the specified tiles are now considered and stream ID s are also set for those. This PR solves another issue : if stray white-space characters are present in AIE_profile_settings metrics configurations, it caused the comparison with valid metrics to fail. This resulted in selection of default metrics even if an otherwise valid metric was specified.

What has been tested and how, request additional testing if necessary

Reported test with tile ranges and also particular tile specification.

Documentation impact (if any)

IshitaGhosh avatar Aug 11 '22 19:08 IshitaGhosh

Build Failed! :(

gbuildx avatar Aug 11 '22 21:08 gbuildx

retest this please.

dayeh-xilinx avatar Aug 11 '22 22:08 dayeh-xilinx

Build Failed! :(

gbuildx avatar Aug 12 '22 00:08 gbuildx

retest this please.

dayeh-xilinx avatar Aug 12 '22 01:08 dayeh-xilinx

Build Failed! :(

gbuildx avatar Aug 12 '22 03:08 gbuildx

retest this please.

dayeh-xilinx avatar Aug 12 '22 05:08 dayeh-xilinx

Build Failed! :(

gbuildx avatar Aug 12 '22 08:08 gbuildx

Build Passed!

gbuildx avatar Aug 18 '22 04:08 gbuildx

Build Failed! :(

gbuildx avatar Aug 18 '22 11:08 gbuildx

Build Passed!

gbuildx avatar Aug 22 '22 14:08 gbuildx