XRT icon indicating copy to clipboard operation
XRT copied to clipboard

XRT Version extraction scheme does not work when building from tagged releases

Open bryanloz-xilinx opened this issue 2 years ago • 0 comments

For instance if you try to build XRT from a tagged release such as:

https://github.com/Xilinx/XRT/archive/refs/tags/202210.2.13.466.tar.gz

You will see errors when building, such as:

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

And the generated / included version.json and version.h will have the incorrect release number.

In this case, it will state "2.13.0" instead of "2.13.466".

bryanloz-xilinx avatar Jun 21 '22 00:06 bryanloz-xilinx