XRT icon indicating copy to clipboard operation
XRT copied to clipboard

CMAKE_INSTALL_PREFIX is not honored

Open bryanloz-xilinx opened this issue 2 years ago • 2 comments

The XRT package is not relocatable.

https://github.com/Xilinx/XRT/blob/master/src/CMakeLists.txt#L69

/opt/xilinx is hardcoded in 56 different files within XRT.

bryanloz-xilinx avatar Jun 19 '22 20:06 bryanloz-xilinx

@gbuildx @NaAl-Xlnx Can you please take a look at the build pipelines and make sure that /opt/xilinx or /opt/xilinx/xrt is not hardcoded anywhere in the build pipeline or in any automated tests?

In the near future we would like to install XRT to /usr/ by default.

bryanloz-xilinx avatar Jun 21 '22 16:06 bryanloz-xilinx

@stsoe what is the status of this issue? In the discussion under #6779 you mention that you want to address this issue but "will not promise a quick fix".

I would like to weight in that XRT not being relocatable is a problem for the large project I work on. Knowing when we could expect a fix for this could be of great help. Thanks!

qberthet avatar Oct 23 '23 16:10 qberthet

Now that #7835 is merged, shouldn't this issue be closed ? Or is there still something else to it? Thanks!

qberthet avatar Apr 09 '24 15:04 qberthet

Thanks @qberthet. The PR was missing meta comment for closing the issue.

stsoe avatar Apr 09 '24 15:04 stsoe