XRT
XRT copied to clipboard
Xilinx
CR-1129020 Need to add new PS kernel validate tests to xbutil validate
Problem solved by the commit
https://jira.xilinx.com/browse/CR-1129020 For vck5000 Discovery platform there are 4 new PS kernel validate tests that need to be added to xbutil validate flow.
The tests are all checked into XRT repo pending final merge:
tests/validate/ps_validate_test
tests/validate/ps_bandwidth_test
tests/validate/ps_aie_test
tests/validate/ps_iops_test
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
New tests so no bugs!
How problem was solved, alternative solutions (if any) and why they were rejected
Added the tests into the xbutil validate testing framework
Risks (if any) associated the changes in the commit
Currently the tests do not perform well and need some updating. However
What has been tested and how, request additional testing if necessary
Note that some tests may fail but they are invoking the correct test ps-aie
dbenusov@xsjchrisd42:/proj/rdi/staff/dbenusov/XRT$ xbutil validate -r ps-aie -d 17:00 Starting validation for 1 devices
Validate Device : [0000:17:00.1]
Platform : xilinx_vck5000_gen4x8_xdma_base_2
SC Version : 4.4.32
Platform ID : 04624343-B44B-B0A1-3CD4-8A411789FF20
-------------------------------------------------------------------------------
Test 1 [0000:17:00.1] : ps-aie
Test Status : [PASSED]
-------------------------------------------------------------------------------
Validation completed. Please run the command '--verbose' option for more details
dbenusov@xsjchrisd42:/proj/rdi/staff/dbenusov/XRT$ echo $?
0
ps-validate
dbenusov@xsjchrisd42:/proj/rdi/staff/dbenusov/XRT$ xbutil validate -r ps-validate -d 17:00
Starting validation for 1 devices
Validate Device : [0000:17:00.1]
Platform : xilinx_vck5000_gen4x8_xdma_base_2
SC Version : 4.4.32
Platform ID : 04624343-B44B-B0A1-3CD4-8A411789FF20
-------------------------------------------------------------------------------
Test 1 [0000:17:00.1] : ps-validate
[=> ] 7%: Running Test... < 22s >
Error(s) : waitpid(2) failed: No child processes
Test Status : [FAILED]
-------------------------------------------------------------------------------
Validation failed. Please run the command '--verbose' option for more details
ps-bw
dbenusov@xsjchrisd42:/proj/rdi/staff/dbenusov/XRT$ xbutil validate -r ps-bw -d 17:00
Starting validation for 1 devices
Validate Device : [0000:17:00.1]
Platform : xilinx_vck5000_gen4x8_xdma_base_2
SC Version : 4.4.32
Platform ID : 04624343-B44B-B0A1-3CD4-8A411789FF20
-------------------------------------------------------------------------------
Test 1 [0000:17:00.1] : ps-bw
[=> ] 9%: Running Test... < 28s >
Error(s) : waitpid(2) failed: No child processes
Test Status : [FAILED]
-------------------------------------------------------------------------------
Validation failed. Please run the command '--verbose' option for more details
ps-iops
dbenusov@xsjchrisd42:/proj/rdi/staff/dbenusov/XRT$ xbutil validate -r ps-iops -d 17:00
Starting validation for 1 devices
Validate Device : [0000:17:00.1]
Platform : xilinx_vck5000_gen4x8_xdma_base_2
SC Version : 4.4.32
Platform ID : 04624343-B44B-B0A1-3CD4-8A411789FF20
-------------------------------------------------------------------------------
Test 1 [0000:17:00.1] : ps-iops
Error(s) : TEST FAILED: failed to load xclbin: Input/output error
XRT build version: 2.14.0
Build hash: f67ae0ebf5d3b84e15809d884dd43b80e83f81d3
Build date: 2022-05-05 12:32:20
Git branch: CR-1129020
PID: 26655
UID: 90228
[Thu May 5 20:41:52 2022 GMT]
HOST: xsjchrisd42
EXE:
/proj/xsjhdstaff6/dbenusov/XRT/build/Debug/opt/xilinx/xrt/test/ps_iops_test.exe
[XRT] ERROR: See dmesg log for details. err = -5
Test Status : [FAILED]
-------------------------------------------------------------------------------
Validation failed. Please run the command '--verbose' option for more details
dbenusov@xsjchrisd42:/proj/rdi/staff/dbenusov/XRT$ echo $?
1
Documentation impact (if any)
xbutil validate docs need to have new tests added into the list
Please do let me know what you find out about the data driven implementation regarding the xclbin names. These new tests should be data driven and not hardcoded in the SubCmdValidate.cpp file.
It seems that the xclbin file names are hardcoded in the host executable files, so it is safe to remove the xclbin file names from SubCmdValidate. In fact, they can be removed for any test that uses a host executable. The xclbin names must remain for tests that program a device such as the dma test.
It appears that the python scripts also currently require the xclbin names to function properly. I will be reverting the removal of the xclbin names for the older tests in this PR. The new tests will not specify an xclbin name to set the future standard
No dice on removing any xclbin names. There will need a separate PR to remove them as removing the xclbin names will require a good deal of refactoring.
