Read DCP crash in EDIFParser

[pongstorn-xilinx]

Recent changes in master cause the crash while reading DCP.

[zhilix]

hi, did this issue get fixed? Recently I am running on some experiments and had the error:

Exception in thread "main" com.xilinx.rapidwright.edif.EDIFParseException: Parsing Error: Expected token: comment|metax, encountered: property before byte offset 281.
        at com.xilinx.rapidwright.edif.AbstractEDIFParserWorker.expect(AbstractEDIFParserWorker.java:141)
        at com.xilinx.rapidwright.edif.AbstractEDIFParserWorker.parseStatus(AbstractEDIFParserWorker.java:258)
        at com.xilinx.rapidwright.edif.EDIFParser.parseEDIFNetlist(EDIFParser.java:92)
        at b.a(Unknown Source)
        at b.a(Unknown Source)
        at com.xilinx.rapidwright.design.Design.readCheckpoint(Unknown Source)
        at com.xilinx.rapidwright.interchange.PhysicalNetlistExample.main(PhysicalNetlistExample.java:56)

Is this the read DCP crash that you are referring to? Thanks!

[clavin-xlnx]

@zhilix - I don't think this is the same error. However, could you post the example DCP or EDIF that is causing the issue?

[zhilix]

FPGA03.zip https://drive.google.com/file/d/1U7Pf7GCXfJKeXg3BgYeXi788y81dxYZs/view?usp=drive_web Hi Chris,

Here is the dcp and edf file. It's large and I have to share with the link. Thanks!

Zhili

On Wed, Jul 6, 2022 at 3:37 PM Chris Lavin @.***> wrote:

@zhilix https://github.com/zhilix - I don't think this is the same error. However, could you post the example DCP or EDIF that is causing the issue?

— Reply to this email directly, view it on GitHub https://github.com/Xilinx/RapidWright/issues/415#issuecomment-1176702555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVP4C4ZRNXJI6YOEAXTXEETVSXVBZANCNFSM5VVQV6EA . You are receiving this because you were mentioned.Message ID: @.***>

[clavin-xlnx]

FPGA03.zip https://drive.google.com/file/d/1U7Pf7GCXfJKeXg3BgYeXi788y81dxYZs/view?usp=drive_web Hi Chris, Here is the dcp and edf file. It's large and I have to share with the link. Thanks! Zhili Sorry Zhili, I couldn't access the file. You might need to change sharing permissions.

[zhilix]

I just updated the sharing, you can try now. Thanks

[clavin-xlnx]

Just tried to run the design:

java com.xilinx.rapidwright.interchange.PhysicalNetlistExample design.dcp design.edf design_out.dcp

My output was:

Removing Parser@35966878, it started past the last cell.
Removing Parser@71933756, it started past the last cell.
Removing Parser@107900634, it started past the last cell.
Removing Parser@143867512, it started past the last cell.
Removing Parser@179834390, it started past the last cell.
Removing Parser@215801268, it started past the last cell.
Removing Parser@251768146, it started past the last cell.
==============================================================================
==                       DCP->Interchange Format->DCP                       ==
==============================================================================
                Read DCP:    20.077s
   Write Logical Netlist:     7.418s
  Write Physical Netlist:     0.095s
    Read Logical Netlist:    42.369s
   Read Physical Netlist:     0.507s
               Write DCP:     7.086s
------------------------------------------------------------------------------
         [No GC] *Total*:    77.552s

I was not able to reproduce the issue on the latest RapidWright from master. Would you mind trying again after doing a git pull and ./gradlew update_jars and re-compiling?

[zhilix]

Thanks! I think I figured it out. The thing is, If I run the command java com.xilinx.rapidwright. interchange.PhysicalNetlistExample design.dcp design_out.dcp, without the design.edf, there will be the errors; but if I run the command with design.edf added like you used, it can succeed.

On Wed, Jul 6, 2022 at 11:17 PM Chris Lavin @.***> wrote:

Just tried to run the design:

java com.xilinx.rapidwright.interchange.PhysicalNetlistExample design.dcp design.edf design_out.dcp

My output was:

Removing @., it started past the last cell. Removing @., it started past the last cell. Removing @., it started past the last cell. Removing @., it started past the last cell. Removing @., it started past the last cell. Removing @., it started past the last cell. Removing @.***, it started past the last cell.

== DCP->Interchange Format->DCP ==

            Read DCP:    20.077s

Write Logical Netlist: 7.418s Write Physical Netlist: 0.095s Read Logical Netlist: 42.369s Read Physical Netlist: 0.507s Write DCP: 7.086s

     [No GC] *Total*:    77.552s

I was not able to reproduce the issue on the latest RapidWright from master. Would you mind trying again after doing a git pull and ./gradlew update_jars and re-compiling?

— Reply to this email directly, view it on GitHub https://github.com/Xilinx/RapidWright/issues/415#issuecomment-1177045330, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVP4C44SHELG6YWEV4H4YGLVSZK4PANCNFSM5VVQV6EA . You are receiving this because you were mentioned.Message ID: @.***>

[clavin-xlnx]

Closing for now as I believe this was fixed.