PYNQ icon indicating copy to clipboard operation
PYNQ copied to clipboard

Correct environment variables

Open dspsandbox opened this issue 4 years ago • 2 comments

The Pynq build flow always goes through bitstream generation, microbalze BSPs, binaries... even in case a PYNQ_SDIST is specified. This is because BOARDDIR and DEFAULT_BOARDDIR variables are not part of the environment when launching /sdbuild/packages/pynq/pre.sh.

dspsandbox avatar Nov 29 '21 15:11 dspsandbox

Thank you for the contribution - give us some time to verify this as part of next image build release.

schelleg avatar Dec 04 '21 00:12 schelleg

Codecov Report

Merging #1323 (432250c) into master (59515a9) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 432250c differs from pull request most recent head 206c4f9. Consider uploading reports for the commit 206c4f9 to get more accurate results Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1323    +/-   ##
========================================
  Coverage   46.47%   46.47%            
========================================
  Files          28       28            
  Lines        4953     4953            
  Branches      827      971   +144     
========================================
  Hits         2302     2302            
  Misses       2594     2594            
  Partials       57       57            

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59515a9...206c4f9. Read the comment docs.

codecov-commenter avatar Dec 04 '21 00:12 codecov-commenter

we are heavily updating sdbuild, so will close this one out just now w/o accepting ... thank you for contributing.

schelleg avatar Sep 21 '22 16:09 schelleg