SPHinXsys icon indicating copy to clipboard operation
SPHinXsys copied to clipboard

delete functions in solid particle

Open Xiangyu-Hu opened this issue 10 months ago • 1 comments

https://github.com/Xiangyu-Hu/SPHinXsys/blob/ea091def9749e736b798016efd994b1f8898e2d1/src/shared/particles/solid_particles.h#L90-L131

In order to achieve separation between particle class from physical method classes, I am going to clean all particles so that at last only base particles left. For this, I need to clean all functions in particles classes.

@BenceVirtonomy @FabienPean-Virtonomy Could you help to move these functions out, or I can delete if they are not useful anymore?

Xiangyu-Hu avatar Apr 25 '24 19:04 Xiangyu-Hu

In order to achieve separation between particle class from physical method classes, I am going to clean all particles so that at last only base particles left. For this, I need to clean all functions in particles classes.

I agree that they should be free functions, they can be cut out of the ElasticSOlidParticles class

FabienPean-Virtonomy avatar May 03 '24 08:05 FabienPean-Virtonomy

This is done in #582.

Xiangyu-Hu avatar Jun 19 '24 16:06 Xiangyu-Hu