SPHinXsys icon indicating copy to clipboard operation
SPHinXsys copied to clipboard

fluid shell interaction model.

Open DrChiZhang opened this issue 2 years ago • 9 comments

1, add fluid shell interaction dynamics. 2, add new test case of sloshing flow with baffle 3, generalise complex dynamics according with adding third contact body to contact body list.

DrChiZhang avatar Dec 15 '22 14:12 DrChiZhang

@ChiZhangatTUM We would like to make a 3d test here too. I was wondering if you already have the elastic beam in a flow case at least in 2d? I mean test_2d_fsi2 case with the shell? I'm asking you to avoid doing something you have done already. If you have it, I would try to expand it to 3d otherwise build it from scratch.

BenceVirtonomy avatar Dec 18 '22 10:12 BenceVirtonomy

@ChiZhangatTUM We would like to make a 3d test here too. I was wondering if you already have the elastic beam in a flow case at least in 2d? I mean test_2d_fsi2 case with the shell? I'm asking you to avoid doing something you have done already. If you have it, I would try to expand it to 3d otherwise build it from scratch.

Sure, I have already done some work. You can follow tests/user-exampels/test-2d-square-fsi in fluid-shell-interaction branch .

DrChiZhang avatar Dec 18 '22 11:12 DrChiZhang

@ChiZhangatTUM We would like to make a 3d test here too. I was wondering if you already have the elastic beam in a flow case at least in 2d? I mean test_2d_fsi2 case with the shell? I'm asking you to avoid doing something you have done already. If you have it, I would try to expand it to 3d otherwise build it from scratch.

Sure, I have already done some work. You can follow tests/user-exampels/test-2d-square-fsi in fluid-shell-interaction branch .

Ahh, I see. Could you make a draft PR from that branch? That way we can all see the changes there too.

BenceVirtonomy avatar Dec 18 '22 14:12 BenceVirtonomy

1, add fluid shell interaction dynamics. 2, add new test case of sloshing flow with baffle 3, generalise complex dynamics according with adding third contact body to contact body list.

Dear Chi, I think that we need a discussion on the pull request to clarify several issues.

Xiangyu-Hu avatar Dec 19 '22 09:12 Xiangyu-Hu

1, add fluid shell interaction dynamics. 2, add new test case of sloshing flow with baffle 3, generalise complex dynamics according with adding third contact body to contact body list.

Dear Chi, I think that we need a discussion on the pull request to clarify several issues.

Sure, I will be office from Tuesday to Thursday.

DrChiZhang avatar Dec 19 '22 09:12 DrChiZhang

Hi all, As we have lots of issues on this PR. I will close it without merging in the following days.

DrChiZhang avatar Dec 19 '22 09:12 DrChiZhang

Hi all, As we have lots of issues on this PR. I will close it without merging in the following days.

You don't need to close it Chi, unless you want to start from scratch. You can set it back to draft so that we can still see the changes.

BenceVirtonomy avatar Dec 19 '22 10:12 BenceVirtonomy

I will add it to the user_examples of this current branch in the next commit, and you can modify and add it to test with proper validation.

DrChiZhang avatar Dec 20 '22 10:12 DrChiZhang

@ChiZhangatTUM is the fluid-shell-interaction your new branch? can you please make a PR from that and close this one? Thx!

BenceVirtonomy avatar Jan 17 '23 10:01 BenceVirtonomy