notepad2-mod icon indicating copy to clipboard operation
notepad2-mod copied to clipboard

"short" is not a javascript keyword

Open ghost opened this issue 7 years ago • 4 comments

seen here

https://github.com/XhmikosR/notepad2-mod/blob/30364fb5afb4e653bb6f7f42f1c7122cbe7ddf33/src/Styles.c#L616-L622

here is a sane list:

https://github.com/zufuliu/notepad2/blob/efe02fd4f532ba6159defcc1be54694d1ccdb68b/src/EditLexers/stlJavaScript.c#L8-L10

ghost avatar May 11 '18 02:05 ghost

short was a future reserved word in EcmaScript version 3 and so were int, byte, char, goto, long, final, float, short, double, native, throws, boolean, abstract, volatile, transient, and synchronized. So it may be a good idea to mantain them...

(https://www-archive.mozilla.org/js/language/E262-3.pdf)

rsvargas avatar May 11 '18 17:05 rsvargas

@rsvargas current EcmaScript doesnt define it, so it may be a bad idea to maintain it:

short
ReferenceError: short is not defined [Learn More]

ghost avatar May 11 '18 17:05 ghost

Many of these reserved words are abandoned in ECMAScript 4 and above, they are just Java keywords or reserved words, and most modern browsers/clients supports at least ECMAScript 5 (2009), most developers write scripts target this version and above, that's why they are commented out in line 16:

// ECMAScript 1 till 3
//"abstract boolean byte char double final float goto int long native short synchronized throws transient volatile "

zufuliu avatar May 11 '18 23:05 zufuliu

@zufuliu you should clarify that they are commented out with your version, not this one - cheers

ghost avatar May 11 '18 23:05 ghost