find-unused-sass-variables icon indicating copy to clipboard operation
find-unused-sass-variables copied to clipboard

Combine Folders Feature Added

Open danny007in opened this issue 4 years ago • 6 comments

Can combine folders with another folder and lint within as same array result

Normal without combine

fusv build/scss node_modules/bootstrap/scss

FdsKcLcIZc

With combine Feature

fusv build/scss node_modules/bootstrap/scss -c

UG46BlC9X7

danny007in avatar Jan 03 '21 04:01 danny007in

can merge

danny007in avatar Jan 19 '21 17:01 danny007in

I like this feature. I am currently trying to rebase it with PR #125 to avoid conflicts. Hope you don't mind

gentzeng avatar Jan 30 '21 15:01 gentzeng

I like this feature. I am currently trying to rebase it with PR #125 to avoid conflicts. Hope you don't mind

No dont do now plz, Because #125 as some conflicts

danny007in avatar Jan 30 '21 15:01 danny007in

Year, that is exactly what I meant. I just fetched your PR #115 to my local repository to update it and to propose it to you. I'm not changing anything here and will notice you, when my proposal is ready for your review

gentzeng avatar Jan 30 '21 16:01 gentzeng

Year, that is exactly what I meant. I just fetched your PR #115 to my local repository to update it and to propose it to you. I'm not changing anything here and will notice you, when my proposal is ready for your review

I am editing here https://github.com/XhmikosR/find-unused-sass-variables/pull/124 so wait

danny007in avatar Jan 30 '21 16:01 danny007in

Alright

gentzeng avatar Jan 30 '21 16:01 gentzeng

does this feature implemented in main branch?

danny007in avatar Feb 18 '23 08:02 danny007in

I don't think it is. You could try rebasing and maybe @GeoSot or I could have a look later.

XhmikosR avatar Mar 16 '23 16:03 XhmikosR

This needs a proper rebase and make sure that lint and tests pass. Feel free to make a proper, new PR.

XhmikosR avatar Apr 28 '23 12:04 XhmikosR