Noisette-Obfuscator icon indicating copy to clipboard operation
Noisette-Obfuscator copied to clipboard

Don't rename event accessors

Open privateunit opened this issue 8 years ago • 2 comments

@XenocodeRCE Hello! I'd like to provide you information about the particular issue that I found in the renaming behaviour.

case

It's currently renaming event accessor methods (add & remove) that's should be untouched to prevent arising "missing implementation" exceptions.

Add additional checks in the AnalyzeMember(MethodDef method) method of RenameAnalyzer type like this one:

if (method.IsSpecialName && (method.IsAddOn || method.IsRemoveOn)) return false;

case

privateunit avatar Aug 31 '16 10:08 privateunit

@privateunit have you got any informations about why they shouldn't be renamed ?

Also at this point you can easily make a pull request

XenocodeRCE avatar Sep 19 '16 09:09 XenocodeRCE

+1 method.IsStaticConstructor also important

Rottweiler avatar Aug 23 '18 02:08 Rottweiler