XenoAmess
XenoAmess
> We cannot release with a component with a snapshot dependency on another, so until Commons Lang is released, Commons Text can have it's own version of the method. @garydgregory...
@garydgregory so what is your opinions about this pr? And should I try to resolve conflict now?
@garydgregory rebased. please find some time to review. thanks.
> The CI flagged failing tests are not stemming from any code that I have touched, > How to resolve? checkstyles fails. https://travis-ci.com/github/apache/commons-collections/jobs/508633787 [ERROR] src/main/java/org/apache/commons/collections4/IterableUtils.java:[574,21] (whitespace) WhitespaceAfter: ',' is not...
@garydgregory This pr is a performance refine pr. I add some jmh test for this pr after you asking it.
jmh result: ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/1 .21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING:...
@garydgregory rebased. please find some time to review. thanks.
IMO seems the biggest bc-breaking in this pr is changing JarFileObject's super class from ZipFileObject to AbstractFileObject, thus codes like this will break: ``` ZipFileObject getZipFileObject(...){ ... return someJarFileObjectOrZipFileObject; }...
> Maybe what we need is a Commons Compress provider..., then all that Commons Compress can do we can surface from a single provider. Thoughts? Good idea, that reminds me...
Hi. I think this pr does not need jmh test. If you still need it, I will do it, but I will just not do it until someone tell me...