Xeeynamo
WIP: Disassemble PSP dra.bin
Is this ready for review or still a draft?
Still a draft. I removed dra_psp and stwrp_psp from Makefile.psp.mk, which is why the CI is green. But this is not ready to be merged until we can get these overlays compiled and :ok:
Do we want to keep this draft open, or has it been long enough (and the project shifted enough) that it would make more sense to start over with making DRA PSP? It would be nice to at least have the PSP symbols pulled in, so that anyone using PSP to aid in decompiling the overlays will have correct function names
Do we want to keep this draft open, or has it been long enough (and the project shifted enough) that it would make more sense to start over with making DRA PSP? It would be nice to at least have the PSP symbols pulled in, so that anyone using PSP to aid in decompiling the overlays will have correct function names
If you look at the list of commits there have been some effort from @sozud to match PSP functions. The symbol list is also quite important in this. I am not sure if these functions are in sync with the main branch. Otherwise we can bring this PR up-to-date with a simple rebase. Are you planning to work on this?
I would consider working on this depending on what actually needs to be done still, I can at least give it a try. I'm just not sure what is still not working. I'll see about pulling this branch and then maybe I'll make a PR into your branch, which would allow this PR 1119 to go through.
I would consider working on this depending on what actually needs to be done still, I can at least give it a try. I'm just not sure what is still not working. I'll see about pulling this branch and then maybe I'll make a PR into your branch, which would allow this PR 1119 to go through.
Let me stash what I am working on at the moment and rebase this branch on the latest changes. I do not remember what was not working, but I recall some issues with the rodata part
Just bumping here to make sure we don't forget to merge this branch into master, now that we merged in my fixes. No hurry, just don't want us to forget to finalize the fixes by letting psp into master :)
Just bumping here to make sure we don't forget to merge this branch into master, now that we merged in my fixes. No hurry, just don't want us to forget to finalize the fixes by letting psp into master :)
I am thinking it would be good to discover a few more function symbols, but we're very close to have this merged
Is there a benefit to waiting until we have symbols to merge? My thinking is that merging and having the code co-existing, and starting to get some decompiled functions in, will make it easy to start discovering many symbols quickly.
Is there a benefit to waiting until we have symbols to merge? My thinking is that merging and having the code co-existing, and starting to get some decompiled functions in, will make it easy to start discovering many symbols quickly.
Fair point. Let's get this merged then!