XLT icon indicating copy to clipboard operation
XLT copied to clipboard

Secret properties don't override their plain counterpart

Open rschwietzke opened this issue 2 years ago • 3 comments

Design spec says: Internally, you should in most cases not have to know that a certain property is secret. Hence a defined property secret.foobar is visible via the property API as secret.foobar and foobar. If a normal property foobar is set, the secret version overwrites it.

rschwietzke avatar Dec 02 '22 08:12 rschwietzke

To be precise, the secret cannot override it, it must remove it, otherwise we would leak the secret.

rschwietzke avatar Dec 02 '22 09:12 rschwietzke

The property is not accessible normally getProperty but still logged and in the properties when we iterate over. Regular access is not exposing it.

rschwietzke avatar Dec 02 '22 09:12 rschwietzke

If the secret defines key = value, any key that exists will be removed prior to adding the data from the secret. If we onyl set secret.key = value, we don't remove what is already in existence as key but cannot access it via the normal properties only when we get us a copy.

rschwietzke avatar Dec 04 '22 14:12 rschwietzke