nxdk icon indicating copy to clipboard operation
nxdk copied to clipboard

`_lock_file`, `_unlock_file`, and `_fgetc_nolock`

Open glebm opened this issue 1 year ago • 2 comments

Newer versions of libfmt need these 3 Windows functions, would it be possible to add them?

glebm avatar Jul 07 '24 11:07 glebm

Hm, that would require some rework in PDCLib, it doesn't currently expose the function without locks, and I haven't yet looked too much into the semantics either. For the moment it's probably easier to add a check for nxdk to that ifdef and make libfmt use the fallback version of that class (looks like FMT_USE_FALLBACK_FILE will do that)

thrimbor avatar Jul 07 '24 13:07 thrimbor

The functions are no longer required by libfmt but implementing them will improve performance

glebm avatar Jul 08 '24 21:07 glebm