nxdk icon indicating copy to clipboard operation
nxdk copied to clipboard

Added various features

Open PQCraft opened this issue 1 year ago • 1 comments

#651 died because I suck at using git

Changelog copied from #651:

tools/cxbe:

  • Added the ability to handle long section names (moved the limit from 8 chars to 255)
  • Added an option to set the XBE's title ID to either a hex code (like FFFF0002) or a human-readable code (like CX-9999)
  • Added an option to set the XBE's region flags
  • Added an option to set the XBE's version (can be dec, hex, or oct)

Makefile:

  • Added XBE_TITLEID to define a title ID (goes to cxbe as -TITLEID:$(XBE_TITLEID))
  • Added XBE_REGION to define a title ID (goes to cxbe as -REGION:$(XBE_REGION))
  • Added XBE_VERSION to define a title ID (goes to cxbe as -VERSION:$(XBE_VERSION))

PQCraft avatar Jul 28 '23 18:07 PQCraft

This needs some more cleanup work:

  • Commit titles don't match our pattern (cxbe instead of tools/cxbe, Add instead of Added, missing prefix etc.)
  • Several fix-up commits that undo changes made in previous commits (https://github.com/XboxDev/nxdk/pull/655/commits/8bc1c97ef9b97287eb5c01a86e8d5f9d2947e72b) are not squashed into the commit that was faulty
  • https://github.com/XboxDev/nxdk/pull/655/commits/fbd77464eaa41636456a3e129010133b84c26913 does not need to be a separate commit
  • https://github.com/XboxDev/nxdk/pull/655/commits/2dd28baed327dc8adb68b3164cc0b36b5f54b20f has a rather non-descriptive commit title
  • https://github.com/XboxDev/nxdk/pull/655/commits/44069a50cb6ce8bcbc4a8f5fe7274776a2b448a4 commit title is too long
  • Unrelated changes in the same commit that should instead get split-up and squashed (https://github.com/XboxDev/nxdk/pull/655/commits/303a4999e2c4a3a2b611adedaef63dd32f22cafd)
  • There still are Makefile changes in this PR
  • Commits that don't match the formatting style (https://github.com/XboxDev/nxdk/pull/655/commits/46b848978a917ad5299e4ea46fc5955c9abe202d), this has to be fixed in the faulty commits themselves, not with a separate commit at the end. Each commit should pass a check with clang-format.

We also usually don't use commit messages unless they're absolutely necessary to provide context.

thrimbor avatar Sep 19 '23 13:09 thrimbor