nxdk icon indicating copy to clipboard operation
nxdk copied to clipboard

pbkit: Support non-standard NVCLK

Open GXTX opened this issue 3 years ago • 2 comments
trafficstars

Fixes #536

With the release of software based overclocks, and hardware modding becoming more popular I think pbkit should support any given frequency just as XDK does. A stock Xbox will run fine at ~250MHz and as low as ~25MHz.

GXTX avatar Jun 22 '22 01:06 GXTX

Looks pretty good, tested on my 1.6 with stock clocks and didnt break anything. Got this output:

input freq : 233338Hz
num        : 58334
den        : 7812
timer freq : 31248Hz

Output matches the original hardcoded value of ~31.25Mhz

Ryzee119 avatar Jul 03 '22 07:07 Ryzee119

Thanks for the review. ^

GXTX avatar Jul 18 '22 15:07 GXTX

Closing due to lack of MIT consent.

Ernegien avatar Sep 07 '22 16:09 Ernegien

The code is taken directly from Linux, I cannot re-license Linux.

GXTX avatar Sep 07 '22 16:09 GXTX

Could be rewritten to simplify fractions using a GCD, or you can find a source for fraction simplification using this algorithm to ensure it's factual / non-copyrightable (while also providing a second source).

I think it is already factual, although I don't fully understand the choice of the constant 32 and 5.

JayFoxRox avatar Sep 30 '22 07:09 JayFoxRox