nxdk-pdclib
nxdk-pdclib copied to clipboard
XboxDev
Base version (4f5b433) is outdated
We should rebase to the latest upstream.
The upstream has added some interesting changes since then; click here to see the diff / list of commits. Most interesting:
- scanf fix (closes #16)
- memory leak in fclose
- asctime implementation
- at least 1 fix that we manually pulled (fwrite crash fix)
In the rebase process, we can also fix #17, and remove our hacks / when we pulled in changes manually (like https://github.com/XboxDev/nxdk-pdclib/commit/b770ec63a6e0c0ea8d912f5dace3f06c1c5dc00a and potentially https://github.com/XboxDev/nxdk-pdclib/commit/31473f1a1cae603e30f4130ca3927983268e54b9).
I'm just leaving this comment as reminder and for exposure.
Some of those are critical issues which cause bad behaviour in otherwise correct nxdk apps. We should try to do this in the near future.
It has been almost a year. So I'm leaving this comment for exposure.
Since then, there's also an implementation of fopen_s and friends (which I'll need for a handful of ports).
Looked into this. Lots of work to be done, got stuck bringing up some threading stuff type changed and we lost eventHandle, there's 2 commits we can drop entirely (wchar, gmt), but someone else should look into this.
