obs-StreamFX icon indicating copy to clipboard operation
obs-StreamFX copied to clipboard

Framerate adjustment for Encoders

Open Xaymar opened this issue 1 year ago • 0 comments

Discussion Thread

https://github.com/Xaymar/obs-StreamFX/discussions/845

Provide a summary of the Improvement

It should be possible to split Stream framerate from Recording framerate, so that users do not have to sacrifice either stream or recording quality. Ideally this should be a drop-in class or handled on the encoder factory itself, so that it can easily be reused by future encoders.

Bounty Completion Requirements

  • Easily integratable in future encoder implementations. A junior C/C++ developer should be able to integrate this change within 1 hour of starting.
    • This either means a separate class or direct integration into the common encoder factory.
  • Code should have enough comments to be understood, but not too many.
    • int a = 1; // Assigns 1 to a is pointless.
    • a *= std::max(b/c, log(d)) / log2(e); should definitely have a comment.
    • Multiple comments may be grouped into one block preceding the difficult section.
  • Code is licensed under GPLv2 or later.
  • Zero-Copy and multi-GPU functionality must stay in tact.
  • Framerate adjustment should be integer fraction of the OBS framerate.

There is a $250 open bounty on this issue. Add to the bounty at Bountysource.

Xaymar avatar Aug 04 '22 16:08 Xaymar

Oops accidentally implemented this in almost no time at all.

Xaymar avatar Sep 14 '22 01:09 Xaymar