XamlStyler icon indicating copy to clipboard operation
XamlStyler copied to clipboard

Published 20 hours ago • verified publisher icon Xavalon

Update Newtonsoft.Json package to version 12.0.2

Open grochocki opened this issue 3 months ago • 3 comments

After publishing final feature update supporting VS2017 (#480), we will be unblocked form updating Newtonsoft.Json to version 12.0.2. More information here: Using Newtonsoft.Json in a Visual Studio extension.

grochocki avatar Apr 03 '24 01:04 grochocki

Question out of interest: why is XamlStyler sticking with NewtonSoft.JSON now that System.Text.JSON is available?

hansmbakker avatar Apr 03 '24 06:04 hansmbakker

Question out of interest: why is XamlStyler sticking with NewtonSoft.JSON now that System.Text.JSON is available?

Visual Studio uses Newtonsoft.Json internally and ships with a version. Having extensions ship with a different version of Json.NET can cause hard to debug issues. Obviously, XamlStyler works with more than just VS, but using different serialization libraries in different versions of the tool would introduce new complexities.

Why not remove Json.NET entirely? I assume it comes down to not wanting to create work with no immediate benefit (other than supporting installation on older VS versions).

mrlacey avatar Apr 03 '24 07:04 mrlacey

Why not remove Json.NET entirely

@mrlacey this was what I meant in https://github.com/Xavalon/XamlStyler/issues/481#issuecomment-2033662225

hansmbakker avatar Apr 03 '24 10:04 hansmbakker