XamlStyler icon indicating copy to clipboard operation
XamlStyler copied to clipboard

Published 20 hours ago • verified publisher icon Xavalon

Target to net 7 and 8 in addition to 6

Open virzak opened this issue 2 years ago • 9 comments

Description:

Fixes # (issue)

Checklist:

  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] I have tested my changes by running the extension in VS2017
  • [x] I have tested my changes by running the extension in VS2019
  • [x] I have tested my changes by running the extension in VS2022
  • [x] If changes to the documentation are needed, I have noted this in the description above

virzak avatar Feb 24 '23 21:02 virzak

/azp run

grochocki avatar Aug 15 '23 04:08 grochocki

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 15 '23 04:08 azure-pipelines[bot]

Given that .NET 7 goes out of support on May 14, 2024, I'd suggest adding only .NET 8 instead of 7 and 8.

Other than that, great that you're contributing this!

hansmbakker avatar Jan 24 '24 11:01 hansmbakker

@grochocki having .NET 8 support would really be a welcome update, so that users are not forced to install .NET 6 to run the XamlStyler CLI.

Would it be an idea to do the targetframework update to .NET 8 independent of the other changes in this PR (dependency to Newtonsoft.Json, change in VS SDK version, allowPrerelease in global.json), to unblock this?

(In the meantime, I can add a .NET 8 version of the CLI to my private nuget feed as a workaround)

hansmbakker avatar Jan 25 '24 10:01 hansmbakker

hi，all，can any body tell that what block this, thanks

heartacker avatar Apr 03 '24 01:04 heartacker

Instead of multi-targeting, I'd suggest adding a <RollForward>Major to the xstyle .csproj. This would allow you to continue to build against a single framework version (6.0), but allow the tool to run on future versions without needing to be updated.

https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior

MarkPflug avatar Jun 28 '24 17:06 MarkPflug

We have seen the same issue with XamlStyler and think it would be great if RollForward Major was supported as @MarkPflug mentions.

nietras avatar Jul 11 '24 09:07 nietras

Instead of multi-targeting, I'd suggest adding a <RollForward>Major to the xstyle .csproj. This would allow you to continue to build against a single framework version (6.0), but allow the tool to run on future versions without needing to be updated.

https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior

@MarkPflug That works too. @grochocki what's your opinion?

virzak avatar Jul 17 '24 14:07 virzak