Ldap icon indicating copy to clipboard operation
Ldap copied to clipboard

Package Status

Open strebl opened this issue 9 years ago • 4 comments

Hi @XavRsl

Your package is very useful for me, but it seems you have not the time to maintain it actively. Do you think that changes again?

Can I help you in some way?

I forked your package to get it work with Laravel 5 and added a little feature. Let me know if you think I should create a pull request.

strebl avatar Mar 26 '15 18:03 strebl

Hi @strebl, I'm glad you find this package useful. I've been looking at your forked version (haven't found time to install it yet). It's great to have it laravel 5 compliant, but is it really working as is ? I've updated my CAS package recently and it seems I had to do a lot more things to be L5 ready... Thanks for the removal of the $password variable from the bind() method call. Your globalFilter is interesting but it seems like you force the boolean operator to be AND without allowing it to be OR. Not sure this will please everyone. In fact, I don't really know if I should keep on working on that package. I have the feeling that if I had to work on it I would rewrite it from the ground up. The fact is I now use the Zend LDAP package more and more and although it's a lot heavier and seems overwhelming at first, you can actually achieve a lot more than with my old LDAP package. I need some time to consider this package's future. Thank you for your time, I'll try to come back to you ASAP.

Xavier

XavRsl avatar Mar 30 '15 14:03 XavRsl

Hi Xavier, I'm looking forward to your response on this as well. I think it's a pretty good package to have. Haven't tried Zend LDAP before, would you be able to point me in the right direction?

wwfclim avatar Apr 02 '15 10:04 wwfclim

Hi @XavRsl Yeah it works so far. But I didn't go deep into the package until now. I'll come back to that question in a few days / weeks because now I'll start with the LDAP part of my app.

Until now, I only wrote a little importer command which imports all users to my database. That works fine!

About the global filter: You can still use an OR operator within my global filter to achieve something like that: get all users with a displayname = *bob* but only users inside the organizational unit boston OR california. I can't imagine a situation where I would set a global "OR" filter. Get all users with a displayname = *bob* OR all users in the OU boston OR california. Seems weird to me. Can you give me an example where you would use a global or filter?

For me, the or filter is really useful for queries like: get all users where the displayname is bob OR jane. But that is what your packages handles very well.

The main usage for a global filter, in my opinion is to ignore some users. I'll give you an example. In our LDAP we have some test and system users. all test users have a prefix: test_* and our system user: sys_*. I don't need these users in a end user app, therefore I'd like to exclude them.

I will definitely take a look on the Zend LDAP package. But when I was looking for a ldap package I found that package too. But my first impression was it is kinda verbose and I felt I would have to write a wrapper around the Zend package. Maybe I just wasn't looking close enough!

On the other side, your package has a great API and feels right to me in the Laravel context. :smile: Did you think about a Laravel package for the Zend package?

strebl avatar Apr 02 '15 20:04 strebl

Hi @strebl ! You're right for the AND and OR operators. I have no example of the use of a global OR but I think I remember a user asking me for this feature in an issue. So could you just put back the $this->booleanOperator instead of & ? I've been thinking about writing a wrapper around Zend Ldap. I also wanted to make it Eloquent-like. But the work to achieve this would be a bit overwhelming for me. I've looked at two packages that do something like that : https://github.com/Vinelab/NeoEloquent/ and https://github.com/yajra/laravel-oci8. Very good packages but very complex. So, the good way to go would be to write the API first, then tests, then start writing the package using Zend Ldap in the background (as this would also help me solve issues concerning AD compliance #7 ). The whole structure should also be re-written, the Directory Class should be split into small, more manageable pieces. I'd also like to create a Middleware for LDAP authentication and have Laravel 5 fashion function call ldap()->people(). Sounds like a lot of fun. I think I'll need some help to achieve this. I've made a Trello Board to start getting organized. If you guys wanna join in, please do ! : https://trello.com/b/g7xEVakS/ldap-package-development

Xavier

XavRsl avatar Apr 03 '15 08:04 XavRsl