Valerii Smirnov comments

Results 250 comments of


                                            Valerii Smirnov

The parameter of `singal()` can be omitted, just like `useState()`.

It's not we are starting to provide interface that allows different amount of args. It can cause performance slow down, depending on usage https://jsbench.me/7slty3mtij/1

The parameter of `singal()` can be omitted, just like `useState()`.

But probably impact will be insignificant

The parameter of `singal()` can be omitted, just like `useState()`.

> Did you read my comment? It's already `?` allowed to be not there https://github.com/preactjs/signals/blob/main/packages/core/src/index.ts#L277 Got it. Sorry

fix: fix signals are not reactive on lazy imported components.(#301)

I think its correct. And we should add forwardRef support

`useSignal` should not use `useMemo`

In reality `useMemo` computes once. btw you can use `useState` `useState(() => signal(item))[0]`

signals/react: React components rendered as child routes with React Router don't update when using `signal.value`

@JoviDeCroock Probably it's not actual too, probably it's related with fact only some of high order component have been patched in previous implementation

Creating a empty signal and updating it make the application stop re-rendering

Can you provide stackblitz repro to check?

Creating a empty signal and updating it make the application stop re-rendering

Btw, you should not mutate values of signals. Signals doesn't reacting on mutations. Use `.toSpliced`

Not working with next 13 app directory.

No. I have more flexibility in my own repo. I want to iterate fast on issues and problems

Not working with next 13 app directory.

> @ss-twieland we have a limited amount of time throughout our day and this is something we do in our free time, if XantreDev does not want to contribute back...