evolve icon indicating copy to clipboard operation
evolve copied to clipboard

I'd like you to implement my changes and allow me to post them to workshop.

Open ghost opened this issue 11 years ago • 8 comments

I have many new plugins and fixes.

:)

ghost avatar May 11 '14 21:05 ghost

Seems to be really good ! Hope it will be implemented, i'll try it soon.

ghost avatar May 12 '14 21:05 ghost

Great additions. Do you know if it's possible to restrict the command list to only show what a player has access to?

MuteTM avatar May 13 '14 00:05 MuteTM

@MuteTM

I should be able to add that in. If you want to do it, it should be in either sh_ or sv_commands. At work right now and can't check. Should go along the lines of

if ply:EV_HasPrivelage( ) then <Do normal print stuff> end

ghost avatar May 13 '14 17:05 ghost

Thanks for the tip, I managed to implement it. I'll leave the official implementation to those who can write clean code.

Other notes:

  • Hax still uses functions with Train in them - C&P'd from trainfuck?
  • Money command doesn't check if the gamemode is DarkRP
  • God/Self-God permissions could simply be done how the noclip plugin does them (one perm for self, one perm for others) instead of a different command, AFAIK
  • Norecoil is in sh_spawnprotection.lua - is this intentional?
  • Why change the location of the MOTD file? This breaks compatibility when a person updates evolve

MuteTM avatar May 14 '14 02:05 MuteTM

Why don't you go ahead and send me the code? I can clean it up and implement it faster than writing from scratch.

On 5/13/2014 9:11 PM, MuteTM wrote:

Thanks for the tip, I managed to implement it. I'll leave the official implementation to those who can write clean code.

— Reply to this email directly or view it on GitHub https://github.com/Xandaros/evolve/pull/96#issuecomment-43035316.

ghost avatar May 14 '14 05:05 ghost

Yes! i want this implented alot of commands seem very usefull!

JakeyCakey avatar Aug 23 '14 13:08 JakeyCakey

I definitely love your additions, although for whatever reason when I spawn the evolve:Notify() message has some garbage in it. I called SPOnSpawn(myself) in the server context and it played the message fine. Any other time, though, it comes out with "�l��-,�L$F �" taped to the backend of the message. It doesn't happen when I run the message by itself. (Emphasis mine while trying to test for its cause.) Garbled Text

It happens no matter what, but I believe it has to do with the code on ev_framework.lua#77 due to how it is working with bits / networking the data. I've singled it out to having FAdmin enabled in DarkRP's disabled defaults, which is unfortunate considering how much DarkRP leans on FAdmin. Unfortunately I don't know enough about anything beyond that to be able to offer further solutions.

EntranceJew avatar Sep 20 '14 01:09 EntranceJew

@EntranceJew One of the plugins is passing something that isn't a color or string to evolve:Notify.

thegrb93 avatar Jul 29 '15 19:07 thegrb93