AspNetCore.Diagnostics.HealthChecks icon indicating copy to clipboard operation
AspNetCore.Diagnostics.HealthChecks copied to clipboard

[Feature] Adding Additional Azure Service Bus HealthCheck Checking for healthy Message- and Deadletter-Queue Count

Open mclausen opened this issue 3 years ago • 3 comments

What this PR does / why we need it: As mentioned in #821 this feature creates two new Health Checks for setting a threshold on how many messages that can be in an Azure Service Bus Queue or Dead-letter queue. Internally we use this feature to determine whether our services are running correctly of we see an increased amount of messages in our error that we need to be aware of. We thought others might benefit for this as well 🙌

Adding ServiceBus Queue Message Count Threshold

services
   . AddHealthChecks()
   . AddAzureServiceBusQueueMessageCountThreshold(connectionString: "", queueName: "", degradedThresholdCount: 5, unhealthyThresholdCount: 10);

Adding ServiceBus Deadletter Queue Message Count Threshold

services
   . AddHealthChecks()
   . AddAzureServiceBusDeadLetterQueueMessageCountThreshold(connectionString: "", queueName: "", degradedThresholdCount: 5, unhealthyThresholdCount: 10);

Which issue(s) this PR fixes: #821

Please reference the issue this PR will close: #821

Special notes for your reviewer:

Does this PR introduce a user-facing change?: No it doesn't not change any user-facing changes, it adds an additional user facing feature for people whom uses HealthChecks.AzureServiceBus package

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [x] Unit tests passing
  • [x] End-to-end tests passing
  • [ ] Extended the documentation
  • [ ] Provided sample for the feature

mclausen avatar Aug 18 '21 12:08 mclausen

I would love to provide documentation for this, however I was unable to find the correct markdown 🙈. If you can point me in the right direction I would be happy to add some notes 🙋 ✍️

mclausen avatar Aug 18 '21 14:08 mclausen

@mclausen Please rebase onto master if you are going to continue working on this PR.

sungam3r avatar Feb 23 '22 23:02 sungam3r

ping @mclausen

sungam3r avatar May 30 '22 05:05 sungam3r

@mclausen Do you intend to continue working on that PR?

sungam3r avatar Dec 22 '22 20:12 sungam3r

Superseded by #1861. Thanks @mclausen and @cieciurm.

sungam3r avatar Jul 07 '23 07:07 sungam3r