AspNetCore.Diagnostics.HealthChecks icon indicating copy to clipboard operation
AspNetCore.Diagnostics.HealthChecks copied to clipboard
verified publisher icon Xabaril

Allow dynamodb health check when credentials are not provided in options

Open lisabii opened this issue 5 years ago • 3 comments

Make the options and the credentials of dynamo db check optional. The AWS credentials and region in my project were set in the env params, it will be better to allow the user to leave the options empty. Unit test added and fully tested.

lisabii avatar Jul 16 '20 09:07 lisabii

I'm reading this PR and I think it might solve the same problem https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/653

albertocorrales avatar Oct 19 '20 21:10 albertocorrales

@lisabii Please rebase onto master if you are going to continue work on this PR. Then I can review/merge.

sungam3r avatar Mar 09 '22 21:03 sungam3r

ping @lisabii

sungam3r avatar May 30 '22 05:05 sungam3r

@lisabii Do you intend to continue working on that PR?

sungam3r avatar Dec 22 '22 22:12 sungam3r

Superseded by #1870. Thanks, @lisabii .

sungam3r avatar Jul 06 '23 11:07 sungam3r