AspNetCore.Diagnostics.HealthChecks icon indicating copy to clipboard operation
AspNetCore.Diagnostics.HealthChecks copied to clipboard

chore: update to dotnet 10

Open pregress opened this issue 1 month ago • 2 comments

What this PR does / why we need it: Update to dotnet 10

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer: Do we want to keep support for 8 and 9 or can it be dropped? Need a package update for: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/2016 & https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/pull/2017

Current errors:

E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\test\HealthChecks.UI.Tests\HealthChecks.UI.Tests.csproj : error NU1107:
      Version conflict detected for Microsoft.EntityFrameworkCore.Relational. Install/reference Microsoft.EntityFrameworkCore.Relational 10.0.0 directly to project HealthChecks.UI.Tests to resolve this issue.
       HealthChecks.UI.Tests -> AspNetCore.HealthChecks.UI.SqlServer.Storage -> Microsoft.EntityFrameworkCore.SqlServer 10.0.0 -> Microsoft.EntityFrameworkCore.Relational (>= 10.0.0)
       HealthChecks.UI.Tests -> AspNetCore.HealthChecks.UI.MySql.Storage -> Pomelo.EntityFrameworkCore.MySql 9.0.0 -> Microsoft.EntityFrameworkCore.Relational (>= 9.0.0 && <= 9.0.999).
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\build\docker-images\HealthChecks.UI.Image\HealthChecks.UI.Image.csproj : error NU1107:
      Version conflict detected for Microsoft.EntityFrameworkCore.Relational. Install/reference Microsoft.EntityFrameworkCore.Relational 10.0.0 directly to project HealthChecks.UI.Image to resolve this issue.
       HealthChecks.UI.Image -> AspNetCore.HealthChecks.UI.SqlServer.Storage -> Microsoft.EntityFrameworkCore.SqlServer 10.0.0 -> Microsoft.EntityFrameworkCore.Relational (>= 10.0.0)
       HealthChecks.UI.Image -> AspNetCore.HealthChecks.UI.MySql.Storage -> Pomelo.EntityFrameworkCore.MySql 9.0.0 -> Microsoft.EntityFrameworkCore.Relational (>= 9.0.0 && <= 9.0.999).
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\samples\HealthChecks.UI.StorageProviders\HealthChecks.UI.StorageProviders.csproj : error NU1107:
      Version conflict detected for Microsoft.EntityFrameworkCore.Relational. Install/reference Microsoft.EntityFrameworkCore.Relational 10.0.0 directly to project HealthChecks.UI.StorageProviders to resolve this issue.
       HealthChecks.UI.StorageProviders -> AspNetCore.HealthChecks.UI.SqlServer.Storage -> Microsoft.EntityFrameworkCore.SqlServer 10.0.0 -> Microsoft.EntityFrameworkCore.Relational (>= 10.0.0)
       HealthChecks.UI.StorageProviders -> AspNetCore.HealthChecks.UI.MySql.Storage -> Pomelo.EntityFrameworkCore.MySql 9.0.0 -> Microsoft.EntityFrameworkCore.Relational (>= 9.0.0 && <= 9.0.999).

Also had to exlude / update package for:

E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\src\HealthChecks.Publisher.Prometheus\HealthChecks.Publisher.Prometheus.csproj : error NU1510: Warning As Error: PackageReference Microsoft.Extensions.Diagnostics.HealthChecks will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\src\HealthChecks.Prometheus.Metrics\HealthChecks.Prometheus.Metrics.csproj : error NU1510: Warning As Error: PackageReference Microsoft.Extensions.Diagnostics.HealthChecks will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\samples\HealthChecks.UI.Oidc\HealthChecks.UI.Oidc.csproj : error NU1902: Warning As Error: Package 'Microsoft.IdentityModel.JsonWebTokens' 7.0.3 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-59j7-ghrg-fj52
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\samples\HealthChecks.UI.Branding\HealthChecks.UI.Branding.csproj : error NU1902: Warning As Error: Package 'Microsoft.IdentityModel.JsonWebTokens' 7.0.3 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-59j7-ghrg-fj52
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\samples\HealthChecks.UI.Branding\HealthChecks.UI.Branding.csproj : error NU1902: Warning As Error: Package 'System.IdentityModel.Tokens.Jwt' 7.0.3 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-59j7-ghrg-fj52
    E:\Dev\GitHub\AspNetCore.Diagnostics.HealthChecks\samples\HealthChecks.UI.Oidc\HealthChecks.UI.Oidc.csproj : error NU1902: Warning As Error: Package 'System.IdentityModel.Tokens.Jwt' 7.0.3 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-59j7-ghrg-fj52

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Unit tests passing
  • [ ] End-to-end tests passing
  • [ ] Extended the documentation
  • [ ] Provided sample for the feature

pregress avatar Nov 14 '25 09:11 pregress

Would it fix https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/issues/2446 ?

molinch avatar Nov 19 '25 13:11 molinch

Would it fix #2446 ?

Since it's entity framework related, and there was a lot of rework done in EF 10 chances are high but atm, I'm still unable to compile because of downstream dependency

pregress avatar Nov 19 '25 13:11 pregress