AspNetCore.Diagnostics.HealthChecks icon indicating copy to clipboard operation
AspNetCore.Diagnostics.HealthChecks copied to clipboard

Add option to configure Azure Service Token Provider for Key Vault check

Open DaleMittleman opened this issue 6 years ago • 4 comments
trafficstars

Giving the developer the opportunity to provide connection string and azure AD instance parameters for the Azure Service Token Provider used by the Key Vault Client

DaleMittleman avatar Jul 26 '19 19:07 DaleMittleman

Hi @DaleMittleman I like the PR, let me a couple of days in order to review and merge ( i start my vacation right now)

unaizorrilla avatar Jul 30 '19 12:07 unaizorrilla

@unaizorrilla @Xabaril this PR is required to be able to connect to KeyVaults using a User Assigned Identity (instead of a System Assigned Identity) since that requires using a connection string.

Is there a chance that you will publish an update to the NuGet package using this PR?

CC @remcorakers

hansmbakker avatar Feb 17 '20 15:02 hansmbakker

@DaleMittleman Please rebase onto master if you are going to continue work on this PR.

sungam3r avatar Feb 24 '22 22:02 sungam3r

ping @DaleMittleman

sungam3r avatar May 30 '22 05:05 sungam3r

@DaleMittleman Do you intend to continue working on that PR?

sungam3r avatar Dec 22 '22 22:12 sungam3r

@marioleed Maybe you can help with this? You posted PRs for Azure Service Bus project. I think that you may be familiar with Azure Key Vault as well.

sungam3r avatar Jan 28 '23 17:01 sungam3r

@sungam3r Latest code is using a TokenCredential, so I don't think this PR's changes should be used anymore. Should probably close it.

marioleed avatar Jan 29 '23 08:01 marioleed

OK.

Closed due to lack of feedback from @DaleMittleman .

sungam3r avatar Jan 29 '23 17:01 sungam3r