Add CPM
What this PR does / why we need it:
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #2006 Special notes for your reviewer:
~~I changed healthchecks_elasticsearch_ci.yml and healthchecks_kafka_ci.yml to make ci green.~~
~~Elasticsearch tests failed because of https://github.com/mariotoffia/FluentDocker/issues/312 and https://github.com/actions/runner-images/issues/9692.~~ ~~So I made a temporary fix based on https://github.com/mariotoffia/FluentDocker/issues/312#issuecomment-2265612108.~~
~~Kafka ci failed because of deprecated images. I did update to new ones.~~
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [X] Code compiles correctly
- [X] Created/updated tests
- [X] Unit tests passing
- [X] End-to-end tests passing
- [ ] Extended the documentation
- [ ] Provided sample for the feature
Thanks to https://github.com/Webreaper/CentralisedPackageConverter contributors who made these changes easy
@adamsitnik, please take a look.
@eerhardt, Could you review this PR? Adding CPM will make it easier for us to target .NET 9.
There are a lot of NU1903 warnings in the project when using VS 17.12.
you can find an example at https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/issues/2317
I just had 2 comments. Everything else looks good to me.
@adamsitnik @unaizorrilla - any concerns with this?
I just had 2 comments. Everything else looks good to me.
@adamsitnik @unaizorrilla - any concerns with this?
Thanks for the review.
Adding CPM will make it easier for us to target .NET 9.
@Alirexaa @unaizorrilla @sungam3r @adamsitnik - do you know of a timeline when HealthChecks 9.0 would be released?