AspNetCore.Diagnostics.HealthChecks icon indicating copy to clipboard operation
AspNetCore.Diagnostics.HealthChecks copied to clipboard

Fix RabbitMQ connection leaks

Open sungam3r opened this issue 6 months ago • 2 comments

fixes #2048

See with this option enabled изображение

sungam3r avatar Feb 02 '24 06:02 sungam3r

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fb04fe8) 0.00% compared to head (706fcd4) 64.42%. Report is 7 commits behind head on master.

Files Patch % Lines
...yInjection/RabbitMQHealthCheckBuilderExtensions.cs 92.53% 2 Missing and 3 partials :warning:
src/HealthChecks.Rabbitmq/RabbitMQHealthCheck.cs 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2153       +/-   ##
===========================================
+ Coverage    0.00%   64.42%   +64.42%     
===========================================
  Files           7      248      +241     
  Lines         356     8368     +8012     
  Branches       28      586      +558     
===========================================
+ Hits            0     5391     +5391     
- Misses        356     2830     +2474     
- Partials        0      147      +147     
Flag Coverage Δ
RabbitMQ 48.76% <91.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 02 '24 06:02 codecov-commenter

Hi @sungam3r

LGTM but Can you also upgrade the package version on the pr?

unaizorrilla avatar Mar 30 '24 12:03 unaizorrilla