AspNetCore.Diagnostics.HealthChecks icon indicating copy to clipboard operation
AspNetCore.Diagnostics.HealthChecks copied to clipboard

Add package for SurrealDB

Open Odonno opened this issue 2 years ago • 5 comments

What this PR does / why we need it:

Add a new HealthChecks package to support the SurrealDB database.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

N/A

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [x] Unit tests passing
  • [x] End-to-end tests passing

Odonno avatar Sep 25 '23 16:09 Odonno

Anything else required? @unaizorrilla

Odonno avatar Nov 25 '23 11:11 Odonno

@Odonno thanks. I help to support this project but was away from it for ~6 months. I'll review ASAP.

sungam3r avatar Jan 27 '24 07:01 sungam3r

@Odonno thanks. I help to support this project but was away from it for ~6 months. I'll review ASAP.

Ah, nice to hear! I made some improvements. Should be ok now.

Odonno avatar Jan 27 '24 10:01 Odonno

Maybe one day 🤣

Odonno avatar Mar 17 '24 16:03 Odonno

Codecov Report

Attention: Patch coverage is 77.46479% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 64.22%. Comparing base (73abc7a) to head (2fc9d31).

Files Patch % Lines
...Injection/SurrealDbHealthCheckBuilderExtensions.cs 70.00% 9 Missing :warning:
src/HealthChecks.SurrealDb/SurrealDbHealthCheck.cs 81.08% 3 Missing and 4 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
+ Coverage   64.11%   64.22%   +0.11%     
==========================================
  Files         248      251       +3     
  Lines        8359     8430      +71     
  Branches      586      595       +9     
==========================================
+ Hits         5359     5414      +55     
- Misses       2852     2864      +12     
- Partials      148      152       +4     
Flag Coverage Δ
SurrealDb 31.52% <77.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 17 '24 16:03 codecov-commenter