XVim2 icon indicating copy to clipboard operation
XVim2 copied to clipboard

Undo on develop undoes too much

Open squarefrog opened this issue 8 years ago • 5 comments

Using the latest develop commit ( ec3f7ebcfde4fe48ff09d0557b0a1d729ab310f9 ), undo seems to behave strangely. It seems to undo too much. For example, on master, undo reverts the auto completion of an image literal:

giphy

The same edit using develop seems to undo to the point of my first insertion:

giphy

squarefrog avatar Nov 07 '17 09:11 squarefrog

Please try the latest develop. I discovered I was mis-using the Swift API which has a concept of 'edit transactions', as well as undo groupings. Edit transactions can only be opened/closed on a single pass of the run-loop, whereas undo groupings can exist for multiple passes.

antmd avatar Nov 12 '17 12:11 antmd

I'm still seeing this issue after building from the develop branch

stephensilber avatar Nov 13 '17 06:11 stephensilber

Please try again. Just committed another change to develop.

antmd avatar Nov 13 '17 12:11 antmd

@antmd It seems to be working better, but I'll keep an eye out and let you know if I see any weirdness. Thanks for the quick fix!

stephensilber avatar Nov 13 '17 15:11 stephensilber

@antmd I'm seeing some issues again. It's after Xcode has been open for awhile, this issue starts to come back

stephensilber avatar Nov 28 '17 15:11 stephensilber