Lukáš Laštůvka

Results 49 comments of Lukáš Laštůvka
trafficstars

We overlooked this because I had it selected explicitly, but I have a quick workaround

It would be enough for this method to be static https://github.com/files-community/Files/blob/b2863a3d483e338357d6a283f16cde702cb97088/src/Files.App/ViewModels/Settings/GeneralViewModel.cs#L146-L163 And then you could just use a similar condition for 'en' instead of CultureInfo.InstalledUICulture and store it in ApplicationLanguages.PrimaryLanguageOverride,...

Yes I agree that a plain RAW string is not quite suitable for finding errors and editing later. I would also omit the slash. But splitting would be useful e.g....

Generating a class using resx would certainly be useful, but creating it would not be trivial and the subsequent implementation would have to be on the git side. If you...

> > Generating a class using resx would certainly be useful, but creating it would not be trivial and the subsequent implementation would have to be on the git side....

> Then replace it with underscore. Maybe, switch to '_', is OK.

@0x5bfa I had an idea of how values could be approached. ### Type for keys This would make it possible to group common keys ```csharp public class StringsStandartBase(string key) {...

This is faster because all common keys are grouped under one object. I also thought of using ReadOnlySpan instead of string, but then we would have to use ref struct...

yes it supports both ![image](https://github.com/files-community/Files/assets/84145589/a20fd000-37a5-4828-8316-288861123385) ![image](https://github.com/files-community/Files/assets/84145589/fb05bd2d-4063-4524-baaa-e89c6e43d971) from this data: https://github.com/XTorLukas/Files/blob/305fb4c3d56dd819fca85e4d9f0f7b6b9ac88fa5/src/Files.App.Resources/Strings/en-US/Resources.yml

> Wow!! Comments can be place right above of the resource? Also why not, just they must always be written without the space e.i. "#Comments"