otelsql icon indicating copy to clipboard operation
otelsql copied to clipboard

Sqlcommenter in span

Open LeonPev opened this issue 1 year ago • 2 comments

added sqlcommenter output to the sql.conn.query span for compatibility with js and py packages that have similar behavior

LeonPev avatar Jun 16 '23 12:06 LeonPev

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (eb15273) 80.5% compared to head (ab7f8ba) 80.6%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #177   +/-   ##
=====================================
  Coverage   80.5%   80.6%           
=====================================
  Files         13      13           
  Lines        716     717    +1     
=====================================
+ Hits         577     578    +1     
  Misses       115     115           
  Partials      24      24           
Impacted Files Coverage Δ
conn.go 78.3% <100.0%> (+0.1%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 16 '23 12:06 codecov[bot]

Hi @LeonPev, do you still have an interest in implementing this? I can take this if you are not interested.

XSAM avatar Jul 08 '23 17:07 XSAM