xrpl.js icon indicating copy to clipboard operation
xrpl.js copied to clipboard

feat: Upgrade to Node 18 and remove cross-fetch

Open justinr1234 opened this issue 1 year ago • 2 comments

High Level Overview of Change

  • Upgrade to node.js 18
  • Remove cross-fetch and use native

Fixes #2676

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation Updates
  • [ ] Release

Did you update HISTORY.md?

  • [X] Yes
  • [ ] No, this change does not impact library users

Test Plan

Automated tests

justinr1234 avatar Apr 04 '24 19:04 justinr1234

This should be done in a major version bump.

mvadari avatar Apr 15 '24 12:04 mvadari

FYI: Node 18 has LTS support only until April 2025. We will need to perform a similar obviation of Node 18 at that time

ckeshava avatar Jul 11 '24 18:07 ckeshava

FYI: Node 18 has LTS support only until April 2025. We will need to perform a similar obviation of Node 18 at that time

In the past, for the most part we keep support for the version until we need to remove it or until it's super old.

mvadari avatar Jul 11 '24 19:07 mvadari