[DO NOT MERGE] Amendment XLS-34d

[dangell7]

High Level Overview of Change

Adding functionality for XLS-34d Amendment

Context of Change

• [x] Transactions: Updated Amount - string -> Amount
• [x] Ledger Object: Updated Amount - string -> Amount
• [x] FundWallet: Added links to fund the IOUEscrow dev network
• [x] Test: PaymentChannel: Create, Claim, Fund - Escrow: Create

I added an Issue function on the setup client. I don't like that it runs for each and can move that functionality to the specific test if necessary. Or in the C# client, I issue inside the individual test and will like to refactor that to match.

... paymentChannelTest
await issueIC()

Type of Change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactor (non-breaking change that only restructures code)
• [x] Tests (You added tests for code that already exists, or your new feature included in this PR)
• [ ] Documentation Updates
• [ ] Release

Before / After

XRP ONLY for Payment Channel & Escrow / IOU/XRP for Payment Channel & Escrow

Test Plan

Please review the tests and let me know if you see more. There are much more tests in the rippled library. We can definitely adopt them.

I would like to discuss the gateway setup and having access to an issued token in each test suite.

Summary by CodeRabbit

• New Features

  • Introduced support for cross-chain transactions, including new transaction types such as XChainCreateBridge, XChainClaim, and XChainAddClaimAttestation.
  • Added validation functions for new transaction models to ensure data integrity.

• Bug Fixes

  • Improved error messages in validation processes for various transaction types to reflect expected data types accurately.

• Documentation

  • Updated comments and documentation to clarify expected types and enhance understanding of transaction models.

• Refactor

  • Consolidated flag conversion functions to streamline the codebase and improve maintainability.

• Tests

  • Enhanced test coverage with updated validation checks and error messages for clearer feedback on validation failures.

[mvadari]

lgtm

[socket-security[bot]]

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev