xrpl.js icon indicating copy to clipboard operation
xrpl.js copied to clipboard

signer_lists interface change to match the node response

Open LukaAvbreht opened this issue 2 years ago • 1 comments

High Level Overview of Change

Moved signer_list field from AccountInfoResponse to AccountRoot to match the response from node

Context of Change

Interface change for response typings

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)

LukaAvbreht avatar Jun 09 '22 12:06 LukaAvbreht

Good catch! - If you remove the SignerList import in accountRoot.ts it should resolve the unit test error you're running into.

JST5000 avatar Jun 09 '22 19:06 JST5000

This is actually incorrect - the account_info request does return the signer_lists field in the account_data field, but if you search by ledger ID using the ledger_entry request, you don't get the signer_lists field (because it's in a separate object).

So instead of modifying the AccountRoot LedgerEntry model, the account_info command should really read something like:

account_data: AccountRoot & { signer_lists?: SignerList[] }

mvadari avatar Jan 30 '23 14:01 mvadari

Closed in favor of #2295

mvadari avatar May 01 '23 14:05 mvadari