xrpl-py icon indicating copy to clipboard operation
xrpl-py copied to clipboard

feat: add rippled API v2 support and use as default

Open ckeshava opened this issue 1 year ago • 2 comments

High Level Overview of Change

All the requests are updated to use the newer rippled v2 API responses

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Refactor (non-breaking change that only restructures code)
  • [x] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation Updates
  • [ ] Release

Did you update CHANGELOG.md?

  • [x] Yes
  • [ ] No, this change does not impact library users

Test Plan

Existing integration tests have been modified to use the newer API version responses.

ckeshava avatar Jul 01 '24 18:07 ckeshava

Type of Change should be set to "Breaking change" since response data has changed. Also can you change PR title to: "feat: add rippled API v2 support and use as default"?

khancode avatar Jul 02 '24 12:07 khancode

This PR should be merged into a different branch, called something like 3.0, since this is going to be in a major version bump. That allows us to still merge/deploy other PRs in minor/patch bumps without waiting to be ready for a major version bump.

mvadari avatar Jul 05 '24 15:07 mvadari