xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

`terNO_LINE` and `terNO_RIPPLE` show incorrect explanations

Open mvadari opened this issue 10 months ago • 2 comments

Page: https://xrpl.org/docs/references/protocol/transactions/transaction-results/ter-codes/#ter-codes

Both terNO_LINE and terNO_RIPPLE have this explanation:

Used internally only. This code should never be returned.

This is an incorrect explanation.

mvadari avatar Apr 15 '24 14:04 mvadari

I believe that the tec versions of these codes is normal but the ter version is not normally returned. A search of the rippled source implies this might be correct, but the total code path is unclear.

mDuo13 avatar Apr 15 '24 16:04 mDuo13

I appear to have incorrectly extrapolated from one to the other - that does seem to be true for terNO_LINE, but not terNO_RIPPLE, which does seem to have legitimate code paths. Search link: https://github.com/search?q=repo%3AXRPLF%2Frippled+terNO_RIPPLE&type=code

mvadari avatar Apr 16 '24 08:04 mvadari